linux-kernel - Re: [PATCH] kmemleak: change /sys/kernel/debug/kmemleak permissions from 0444 to 0644

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171006135554.eiwezlqq6gyhy6wa@armageddon.cambridge.arm.com>
Date:   Fri, 6 Oct 2017 14:55:55 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kmemleak: change /sys/kernel/debug/kmemleak permissions
 from 0444 to 0644

On Fri, Oct 06, 2017 at 02:39:25PM +0300, Konstantin Khlebnikov wrote:
> Kmemleak could be tweaked in runtime by writing commands into debugfs file.
> Root anyway can use it, but without write-bit this interface isn't obvious.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> ---
>  mm/kmemleak.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index 7780cd83a495..fca3452e56c1 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -2104,7 +2104,7 @@ static int __init kmemleak_late_init(void)
>  		return -ENOMEM;
>  	}
>  
> -	dentry = debugfs_create_file("kmemleak", S_IRUGO, NULL, NULL,
> +	dentry = debugfs_create_file("kmemleak", 0644, NULL, NULL,
>  				     &kmemleak_fops);
>  	if (!dentry)
>  		pr_warn("Failed to create the debugfs kmemleak file\n");

Acked-by: Catalin Marinas <catalin.marinas@....com>

-- 
Catalin