linux-kernel - Re: [PATCH] vfs: hard-ban creating files with control characters in the name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171006145450.GA18373@bombadil.infradead.org>
Date:   Fri, 6 Oct 2017 07:54:50 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Olivier Galibert <galibert@...ox.com>
Cc:     Adam Borowski <kilobyte@...band.pl>,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vfs: hard-ban creating files with control characters in
 the name

On Thu, Oct 05, 2017 at 12:07:57PM +0200, Olivier Galibert wrote:
> On Tue, Oct 3, 2017 at 5:22 AM, Adam Borowski <kilobyte@...band.pl> wrote:
> > Well, what about just \n then?  Unlike all the others which are relatively
> > straightforward, \n requires -print0 which not all programs implement, and
> > way too many people consider too burdensome to use.
> 
> If you don't use -print0, you're vulnerable to spaces.  Go on, try to
> disallow spaces in file names, I'll pass the popcorn.

The David Wheeler argument for this is to change IFS to "\n\t" from " \n\t".
Personally, I think it's easier to use -print0.