linux-kernel - Re: [PATCH] Input: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2017 18:03:03 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Ben Gamari <ben@...rt-cactus.org>,
        Paul Donohue <linux-kernel@...lsd.com>,
        Masaki Ota <masaki.ota@...alps.com>,
        linux-input@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] Input: Convert timers to use timer_setup()

On Thursday 05 October 2017 02:53:29 Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list
> pointer to all timer callbacks, switch to using the new
> timer_setup() and from_timer() to pass the timer pointer explicitly.
> Adds a pointer back to input device in byd driver.
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: "Pali Rohár" <pali.rohar@...il.com>
> Cc: Ben Gamari <ben@...rt-cactus.org>
> Cc: Paul Donohue <linux-kernel@...lSD.com>
> Cc: Masaki Ota <masaki.ota@...alps.com>
> Cc: linux-input@...r.kernel.org
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> This requires commit 686fef928bba ("timer: Prepare to change timer
> callback argument type") in v4.14-rc3, but should be otherwise
> stand-alone.
> ---
>  drivers/input/ff-memless.c |  8 ++++----
>  drivers/input/mouse/alps.c |  8 ++++----
>  drivers/input/mouse/byd.c  | 10 ++++++----
>  3 files changed, 14 insertions(+), 12 deletions(-)

Looks good,
Acked-by: Pali Rohár <pali.rohar@...il.com>

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)