linux-kernel - Re: [PATCH] Bluetooth: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9F279691-3402-48A2-8E5A-982E65ABCBAF@holtmann.org>
Date:   Fri, 6 Oct 2017 20:38:45 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "bluez mailin list (linux-bluetooth@...r.kernel.org)" 
        <linux-bluetooth@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] Bluetooth: Convert timers to use timer_setup()

Hi Kees,

> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly. As already done in hci_qca, add
> struct hci_uart pointer to priv structure.
> 
> Cc: Marcel Holtmann <marcel@...tmann.org>
> Cc: Gustavo Padovan <gustavo@...ovan.org>
> Cc: Johan Hedberg <johan.hedberg@...il.com>
> Cc: linux-bluetooth@...r.kernel.org
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> This requires commit 686fef928bba ("timer: Prepare to change timer
> callback argument type") in v4.14-rc3, but should be otherwise
> stand-alone.
> ---
> drivers/bluetooth/bluecard_cs.c |  7 +++----
> drivers/bluetooth/hci_bcsp.c    | 10 ++++++----
> drivers/bluetooth/hci_h5.c      | 10 ++++++----
> drivers/bluetooth/hci_qca.c     | 17 ++++++++---------
> 4 files changed, 23 insertions(+), 21 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel