linux-kernel - Re: [PATCH] default implementation for of_find_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLLiU+QZaBti8ifnq6Uf3jQ-ma4v0M=YHxOP5jSZYjG9Q@mail.gmail.com>
Date:   Fri, 6 Oct 2017 17:32:57 -0500
From:   Rob Herring <robh@...nel.org>
To:     Artur Lorincz <larturus2@...il.com>
Cc:     Frank Rowand <frowand.list@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        larturus@...oo.com
Subject: Re: [PATCH] default implementation for of_find_all_nodes(...)

On Wed, Aug 30, 2017 at 1:32 PM, Artur Lorincz <larturus2@...il.com> wrote:
> Added default implementation for of_find_all_nodes(). This function is
> used by board.c from the board module (drivers/staging/board).

Didn't even know we had this... The DT core already has some support
for something like this with "auxdata" that lets you attach DT nodes
to existing platform devices. Why doesn't that work?

In any case, you should just make this code depend on CONFIG_OF. When
there's only 3 other users of this function, that's a good sign we
don't want more. Searching thru all nodes is generally not the right
thing to do.

Rob