lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 7 Oct 2017 20:12:47 +0800 From: Leo Yan <leo.yan@...aro.org> To: "Rafael J. Wysocki" <rjw@...ysocki.net>, Daniel Lezcano <daniel.lezcano@...aro.org>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Stefan Wahren <stefan.wahren@...e.com> Subject: Re: [PATCH 2/2] ARM: cpuidle: replace cpuidle_get_driver with cpuidle_get_cpu_driver On Mon, Sep 04, 2017 at 02:52:14PM +0800, Leo Yan wrote: > commit d50a7d8acd78 ("ARM: cpuidle: Support asymmetric idle definition") > supports multiple CPU idle driver so every CPU has its own driver. When > the initialization fails, the failure handling releases the resources > for every previous CPU; so it needs to retrieve every CPU device and > driver handler and unregister them. But the function > cpuidle_get_driver() can only return current CPU driver handler but not > the iterated CPU driver handler, so it cannot release resource properly. > > This patch is to replace cpuidle_get_driver() with > cpuidle_get_cpu_driver(), every CPU has its own device handler so this > function can get back correct driver handler for the CPU according to > the CPU device handler. By using this CPU driver handler we can release > resource properly. > > Cc: Daniel Lezcano <daniel.lezcano@...aro.org> > Cc: Stefan Wahren <stefan.wahren@...e.com> > Signed-off-by: Leo Yan <leo.yan@...aro.org> > Fixes: d50a7d8acd78 ("ARM: cpuidle: Support asymmetric idle definition") Gentle ping. > --- > drivers/cpuidle/cpuidle-arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c > index f419f6a..ef34780 100644 > --- a/drivers/cpuidle/cpuidle-arm.c > +++ b/drivers/cpuidle/cpuidle-arm.c > @@ -161,9 +161,9 @@ static int __init arm_idle_init(void) > > while (--cpu >= 0) { > dev = per_cpu(cpuidle_devices, cpu); > + drv = cpuidle_get_cpu_driver(dev); > cpuidle_unregister_device(dev); > kfree(dev); > - drv = cpuidle_get_driver(); > cpuidle_unregister_driver(drv); > kfree(drv); > } > -- > 2.7.4 >
Powered by blists - more mailing lists