linux-kernel - Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf8k-hmk4n86foSfSPZxVUQJmGNFkf8ExUKbF2nXaSy8A@mail.gmail.com>
Date:   Sat, 7 Oct 2017 17:03:41 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Vadim Pasternak <vadimp@...lanox.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The structures mlxplat_dev and mlxplat_hotplug are local to the source
> and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'mlxplat_dev' was not declared. Should it be static?
> symbol 'mlxplat_hotplug' was not declared. Should it be static?

Thanks for the patch.
Since Vadim did some rather big driver changes I would like to hear
from him how to proceed with this one: either I apply it now, or after
we get Vadim's series in.

-- 
With Best Regards,
Andy Shevchenko