lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 7 Oct 2017 19:13:16 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com> Cc: Alessandro Zummo <a.zummo@...ertech.it>, "x86@...nel.org" <x86@...nel.org>, Wim Van Sebroeck <wim@...ana.be>, Ingo Molnar <mingo@...hat.com>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Zha Qipeng <qipeng.zha@...el.com>, "H. Peter Anvin" <hpa@...or.com>, "dvhart@...radead.org" <dvhart@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Lee Jones <lee.jones@...aro.org>, Andy Shevchenko <andy@...radead.org>, Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>, linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Platform Driver <platform-driver-x86@...r.kernel.org>, Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@...il.com> Subject: Re: [RFC v4 2/8] platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR updates On Sat, Oct 7, 2017 at 5:33 AM, <sathyanarayanan.kuppuswamy@...ux.intel.com> wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com> > > Currently, update_no_reboot_bit() function implemented in this driver > uses mutex_lock() to protect its register updates. But this function is > called with in atomic context in iTCO_wdt_start() and iTCO_wdt_stop() > functions in iTCO_wdt.c driver, which in turn causes "sleeping into > atomic context" issue. This patch fixes this issue by replacing the > mutex_lock() with spin_lock() to protect the GCR read/write/update APIs. > > Fixes: 9d855d4 ("platform/x86: intel_pmc_ipc: Fix iTCO_wdt GCS memory > mapping failure") I think it need to be a one line. Does it apply on top of v4.14-rc3 ? Btw, this patch should be first in the series. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists