lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 7 Oct 2017 19:13:16 +0300
From:   Andy Shevchenko <>
To:     Kuppuswamy Sathyanarayanan 
Cc:     Alessandro Zummo <>,
        "" <>,
        Wim Van Sebroeck <>,
        Ingo Molnar <>,
        Alexandre Belloni <>,
        Zha Qipeng <>,
        "H. Peter Anvin" <>,
        "" <>,
        Thomas Gleixner <>,
        Lee Jones <>,
        Andy Shevchenko <>,
        Souvik Kumar Chakravarty <>,,,
        "" <>,
        Platform Driver <>,
        Sathyanarayanan Kuppuswamy Natarajan <>
Subject: Re: [RFC v4 2/8] platform/x86: intel_pmc_ipc: Use spin_lock to
 protect GCR updates

On Sat, Oct 7, 2017 at 5:33 AM,
<> wrote:
> From: Kuppuswamy Sathyanarayanan <>
> Currently, update_no_reboot_bit() function implemented in this driver
> uses mutex_lock() to protect its register updates. But this function is
> called with in atomic context in iTCO_wdt_start() and iTCO_wdt_stop()
> functions in iTCO_wdt.c driver, which in turn causes "sleeping into
> atomic context" issue. This patch fixes this issue by replacing the
> mutex_lock() with spin_lock() to protect the GCR read/write/update APIs.

> Fixes: 9d855d4 ("platform/x86: intel_pmc_ipc: Fix iTCO_wdt GCS memory
> mapping failure")

I think it need to be a one line.

Does it apply on top of v4.14-rc3 ?
Btw, this patch should be first in the series.

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists