linux-kernel - Re: [PATCH v5 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcPEtDjFSguTYd=eqfaG7h5hzCPg_d9H5rMK1O390tUBQ@mail.gmail.com>
Date:   Sun, 8 Oct 2017 21:13:19 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     "dvhart@...radead.org" <dvhart@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
        Pali Rohár <pali.rohar@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>, mjg59@...gle.com,
        Christoph Hellwig <hch@....de>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH v5 09/14] platform/x86: dell-smbios: Introduce dispatcher
 for SMM calls

On Sun, Oct 8, 2017 at 6:48 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Sat, Oct 7, 2017 at 7:59 AM, Mario Limonciello
> <mario.limonciello@...l.com> wrote:
>> This splits up the dell-smbios driver into two drivers:
>> * dell-smbios
>> * dell-smbios-smm
>>
>> dell-smbios can operate with multiple different dispatcher drivers to
>> perform SMBIOS operations.
>>
>> Also modify the interface that dell-laptop and dell-wmi use align to this
>> model more closely.  Rather than a single global buffer being allocated
>> for all drivers, each driver will allocate and be responsible for it's own
>> buffer. The pointer will be passed to the calling function and each
>> dispatcher driver will then internally copy it to the proper location to
>> perform it's call.
>
>>  config DELL_SMBIOS
>>         tristate
>
>> +       depends on DELL_SMBIOS_SMM
>> +
>
> If the above dependency is true (which I'm quite sure not) this split
> should never happen.

Hmm... One more thought here.

Which is library and which is not? IOW the question is "can
DELL_SMBIOS be a standalone working module"?

>
>> +config DELL_SMBIOS_SMM
>> +       tristate "Dell SMBIOS calling interface (SMM implementation)"
>> +       depends on DCDBAS
>> +       default DCDBAS
>> +       select DELL_SMBIOS
>>         ---help---
>> +       This provides an implementation for the Dell SMBIOS calling interface
>> +       communicated over SMI/SMM.
>>
>> +       If you have a Dell computer from <=2017 you should say Y or M here.
>> +       If you aren't sure and this module doesn't work for your computer
>> +       it just won't load.


-- 
With Best Regards,
Andy Shevchenko