linux-kernel - Re: [RFC v5 1/8] platform/x86: intel_pmc_ipc: Use spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 8 Oct 2017 21:38:33 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        "x86@...nel.org" <x86@...nel.org>,
        Wim Van Sebroeck <wim@...ana.be>,
        Ingo Molnar <mingo@...hat.com>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Zha Qipeng <qipeng.zha@...el.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Lee Jones <lee.jones@...aro.org>,
        Andy Shevchenko <andy@...radead.org>,
        Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>,
        linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@...il.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kupuswamy@...ux.intel.com>
Subject: Re: [RFC v5 1/8] platform/x86: intel_pmc_ipc: Use spin_lock to
 protect GCR updates

On Sun, Oct 8, 2017 at 1:19 AM,
<sathyanarayanan.kuppuswamy@...ux.intel.com> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
>
> Currently, update_no_reboot_bit() function implemented in this driver
> uses mutex_lock() to protect its register updates. But this function is
> called with in atomic context in iTCO_wdt_start() and iTCO_wdt_stop()
> functions in iTCO_wdt.c driver, which in turn causes "sleeping into
> atomic context" issue. This patch fixes this issue by replacing the
> mutex_lock() with spin_lock() to protect the GCR read/write/update APIs.
>
> Fixes: 9d855d4 ("platform/x86: intel_pmc_ipc: Fix iTCO_wdt GCS memory mapping failure")
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kupuswamy@...ux.intel.com>

>  * Rebased this patch on top of Andy's review branch.

Oh, what I asked you is to use vanilla kernel as a base.
Please, be sure (you assured me, though it's not true) that it's
applied against vanilla (or our fixes branch) and send just this one
patch separately.

No need to resend v5 right now.

-- 
With Best Regards,
Andy Shevchenko