linux-kernel - Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATor59dKq37wEKD3bqcxekEk5WPo-uZ1eBFwW5NJWTUMA@mail.gmail.com>
Date:   Sun, 8 Oct 2017 22:39:42 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     David Daney <ddaney@...iumnetworks.com>
Cc:     linux-gpio@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        David Daney <david.daney@...ium.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-09-22 6:54 GMT+09:00 David Daney <ddaney@...iumnetworks.com>:
> On 09/13/2017 07:37 PM, Masahiro Yamada wrote:
>>
>> This driver implements .alloc() hook, so .map() is not used.
>
>
> Although this comment is true for this driver, it is unclear to me if the
> statement is true in the general case.

If a driver implements .alloc() hook,
irq_domain_check_hierarchy() sets IRQ_DOMAIN_FLAG_HIERARCHY flag.


If you see kernel/irq/irqdomain.c,
alloc/map is selected by irq_domain_is_hierarchy().



-- 
Best Regards
Masahiro Yamada