linux-kernel - Re: [PATCH v2 15/16] gpio: tegra: Use banked GPIO infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfeb33cf-34b5-259d-cf83-f065d75444f3@ti.com>
Date:   Mon, 9 Oct 2017 16:22:29 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     Jonathan Hunter <jonathanh@...dia.com>,
        <linux-gpio@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 15/16] gpio: tegra: Use banked GPIO infrastructure



On 09/28/2017 04:56 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> Convert the Tegra GPIO driver to use the banked GPIO infrastructure,
> which simplifies some parts of the driver.
> 
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>   drivers/gpio/Kconfig      |   1 +
>   drivers/gpio/gpio-tegra.c | 203 ++++++++++++++++++++++------------------------
>   2 files changed, 98 insertions(+), 106 deletions(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index db3e446ad9b3..458157d6d491 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -439,6 +439,7 @@ config GPIO_TEGRA
>   	default ARCH_TEGRA
>   	depends on ARCH_TEGRA || COMPILE_TEST

... 

> @@ -616,76 +617,66 @@ static int tegra_gpio_probe(struct platform_device *pdev)
>   	tgi->ic.irq_set_wake		= tegra_gpio_irq_set_wake;
>   #endif
>   
> +	irq = &tgi->gc.irq;
> +	irq->chip = &tgi->ic;
> +	irq->handler = handle_simple_irq;
> +	irq->lock_key = &tegra_gpio_lock_class;

As per current gpiolib design lockdep lock_class_key is assigned 
automatically and hidden from gpiolib users. 
Why do you need to do the same manually?

> +	irq->default_type = IRQ_TYPE_NONE;
> +	irq->parent_handler = gpio_irq_chip_banked_chained_handler;
> +	irq->update_bank = tegra_gpio_update_bank;
> +
> +	irq->parents = devm_kcalloc(&pdev->dev, tgi->gc.num_banks,
> +				    sizeof(unsigned int), GFP_KERNEL);
> +	if (!irq->parents)
> +		return -ENOMEM;
> +

...

>   
>   	tegra_gpio_debuginit(tgi);
>   
> 

-- 
regards,
-grygorii