linux-kernel - Re: [RFT PATCH v2] gpiolib: allow gpio irqchip to map irqs dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ba9913d-9411-a75d-e7f0-2e9dcd71d742@ti.com>
Date:   Mon, 9 Oct 2017 17:17:16 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Chris Gorman <chrisjohgorman@...il.com>
Subject: Re: [RFT PATCH v2] gpiolib: allow gpio irqchip to map irqs
 dynamically



On 10/09/2017 02:57 PM, Linus Walleij wrote:
> On Mon, Oct 9, 2017 at 8:10 PM, Grygorii Strashko
> <grygorii.strashko@...com> wrote:
> 
>> At the moment it was merged there were no user of irq_base except gpio-mockup.c.
> 
> OK I feel calmer.
> 
>> And actually there are shouldn't as calling irq_create_mapping() in cycle
>> will not guarantee sequential Linux IRQ numbers allocation.
> 
> Yeah. I always felt that was bad practice.
> 
> But we should really kill off that irq_base member from gpio_chip. It looks
> dangerous to have arond.

patch posted.

-- 
regards,
-grygorii