linux-kernel - Re: [PATCH 5/5] trace-cmd: Remove unused view

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171009183228.59982786@gandalf.local.home>
Date:   Mon, 9 Oct 2017 18:32:28 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Michael Sartain <mikesart@...tmail.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] trace-cmd: Remove unused view_width variable

On Sat, 12 Aug 2017 11:30:47 -0600
Michael Sartain <mikesart@...tmail.com> wrote:


This is an annoying warning, but I've kept from doing this because it
reminds me that I have an idea to actually use that variable
someday. But I've just been procrastinating on doing that. ;-)

-- Steve


> Signed-off-by: Michael Sartain <mikesart@...tmail.com>
> ---
>  trace-graph.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/trace-graph.c b/trace-graph.c
> index 1db342f..2c49549 100644
> --- a/trace-graph.c
> +++ b/trace-graph.c
> @@ -1263,7 +1263,6 @@ static void draw_info_box(struct graph_info *ginfo, const gchar *buffer,
>  	gint width, height;
>  	GdkPixmap *pix;
>  	static GdkGC *pix_bg;
> -	gint view_width;
>  	gint view_start;
>  
>  	if (!pix_bg) {
> @@ -1284,7 +1283,6 @@ static void draw_info_box(struct graph_info *ginfo, const gchar *buffer,
>  	height += PLOT_BOARDER * 2;
>  
>  	view_start = gtk_adjustment_get_value(ginfo->hadj);
> -	view_width = gtk_adjustment_get_page_size(ginfo->hadj);
>  	if (x > view_start + width)
>  		x -= width;
>