linux-kernel - Re: [PATCH 2/6] GenWQE: constify pci_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5e23b4b0a5cd36df134d97c61cecb24b@linux.vnet.ibm.com>
Date:   Mon, 09 Oct 2017 09:08:59 +0200
From:   haver <haver@...ux.vnet.ibm.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     bhumirks@...il.com, kernel-janitors@...r.kernel.org,
        "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] GenWQE: constify pci_error_handlers structures

On 2017-08-12 07:44, Julia Lawall wrote:
> These pci_error_handlers structures are only stored in the err_handler
> field of a pci_driver structure, and this field is declared as const.  
> Thus
> the pci_error_handlers structures can be const too.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/misc/genwqe/card_base.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c 
> b/drivers/misc/genwqe/card_base.c
> index 4fd21e8..8650046 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -1333,7 +1333,7 @@ static int genwqe_sriov_configure(struct pci_dev
> *dev, int numvfs)
>  	return 0;
>  }
> 
> -static struct pci_error_handlers genwqe_err_handler = {
> +static const struct pci_error_handlers genwqe_err_handler = {
>  	.error_detected = genwqe_err_error_detected,
>  	.mmio_enabled	= genwqe_err_result_none,
>  	.slot_reset	= genwqe_err_slot_reset,

Fine with me. Thanks for the contribution.

Acked-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>