linux-kernel - Re: [BUG] vt6655: A possible sleep-in-atomic bug in vt6655

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b96d4517-8484-892b-43b8-107067c7f78c@163.com>
Date:   Mon, 9 Oct 2017 15:56:49 +0800
From:   Jia-Ju Bai <baijiaju1990@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     forest@...ttletooquiet.net, simon@...anor.nu, tvboxspy@...il.com,
        scott@...heina.com, dan.a.cashman@...il.com,
        golubev.mikhail@...il.com, bhelgaas@...gle.com,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-pci@...r.kernel.org
Subject: Re: [BUG] vt6655: A possible sleep-in-atomic bug in vt6655_suspend

Okay, I will send a patch :)


Thanks,
Jia-Ju Bai

On 2017/10/9 13:43, Greg KH wrote:
> On Mon, Oct 09, 2017 at 09:10:28AM +0800, Jia-Ju Bai wrote:
>> According to device_main.c, the driver may sleep under a spinlock,
>> and the function call path is:
>> vt6655_suspend (acquire the spinlock)
>>    pci_set_power_state
>>      __pci_start_power_transition (drivers/pci/pci.c)
>>        msleep --> may sleep
>>
>> A possible fix is to replace msleep with mdelay in
>> __pci_start_power_transition in drivers/pci/pci.c.
> Patches are usually best to send in for things that you find like this.
>
> thanks,
>
> greg k-h