linux-kernel - Re: [PATCH] ceph: Fix bool initialization/comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CE98214F-1FB7-4F7A-AB96-102EFF9A725C@redhat.com>
Date:   Mon, 9 Oct 2017 09:52:40 +0800
From:   "Yan, Zheng" <zyan@...hat.com>
To:     Thomas Meyer <thomas@...3r.de>
Cc:     Sage Weil <sage@...hat.com>, idryomov@...il.com,
        ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: Fix bool initialization/comparison



> On 7 Oct 2017, at 22:02, Thomas Meyer <thomas@...3r.de> wrote:
> 
> Bool initializations should use true and false. Bool tests don't need
> comparisons.
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
> 
> diff -u -p a/fs/ceph/caps.c b/fs/ceph/caps.c
> --- a/fs/ceph/caps.c
> +++ b/fs/ceph/caps.c
> @@ -1711,7 +1711,7 @@ void ceph_check_caps(struct ceph_inode_i
> 
> 	/* if we are unmounting, flush any unused caps immediately. */
> 	if (mdsc->stopping)
> -		is_delayed = 1;
> +		is_delayed = true;
> 
> 	spin_lock(&ci->i_ceph_lock);
> 
> @@ -3185,8 +3185,8 @@ static void handle_cap_flush_ack(struct
> 	int dirty = le32_to_cpu(m->dirty);
> 	int cleaned = 0;
> 	bool drop = false;
> -	bool wake_ci = 0;
> -	bool wake_mdsc = 0;
> +	bool wake_ci = false;
> +	bool wake_mdsc = false;
> 
> 	list_for_each_entry_safe(cf, tmp_cf, &ci->i_cap_flush_list, i_list) {
> 		if (cf->tid == flush_tid)

Applied, thanks

Yan, Zheng