linux-kernel - Re: [PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0927e25-3ebb-ffcd-f309-bf4ec758ef47@linaro.org>
Date:   Mon, 9 Oct 2017 11:00:04 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Christos Gkekas <chris.gekas@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cklight: tps65217_bl: Remove unnecessary default
 brightness check

On 08/10/17 22:56, Christos Gkekas wrote:
> Variable val holds the default brightness and is unsigned, therefore
> checking whether it is less than zero is redundant.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@...il.com>

Acked-by: Daniel Thompson <daniel.thompson@...aro.org>

> ---
>   drivers/video/backlight/tps65217_bl.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/tps65217_bl.c b/drivers/video/backlight/tps65217_bl.c
> index fd524ad..61ea82d 100644
> --- a/drivers/video/backlight/tps65217_bl.c
> +++ b/drivers/video/backlight/tps65217_bl.c
> @@ -239,8 +239,7 @@ tps65217_bl_parse_dt(struct platform_device *pdev)
>   	}
>   
>   	if (!of_property_read_u32(node, "default-brightness", &val)) {
> -		if (val < 0 ||
> -			val > 100) {
> +		if (val > 100) {
>   			dev_err(&pdev->dev,
>   				"invalid 'default-brightness' value in the device tree\n");
>   			err = ERR_PTR(-EINVAL);
>