linux-kernel - Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171009103357.kcj2uqse6yv2xepm@earth>
Date:   Mon, 9 Oct 2017 12:33:57 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Lars Poeschel <poeschel@...onage.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio

Hi,

On Mon, Oct 09, 2017 at 11:39:02AM +0200, Lars Poeschel wrote:
> On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote:
> 
> CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as 
> well.
> 
> > On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@...onage.de> wrote:
> > > The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> > > devicetree binding doc as well. So driver and binding doc are in sync
> > > again.
> > > 
> > > Signed-off-by: Lars Poeschel <poeschel@...onage.de>
> > 
> > Are there no new references to the generic pin control binding
> > needed as well?
> 
> Well, yes there is one: As far as I can see it supports the bias-pull-up 
> property.
> My first intention was to have the doc as we have it in the right place, but 
> you are right: It needs an update as well. I can do this, but Sebastian, 
> please keep an eye on that.
> 
> As there are already patches depending on this patch (https://marc.info/?
> l=linux-gpio&m=150726650325394&w=4) I would suggest, that you pull in this 
> patch as is and I do the little update on the doc as a seperate patch.

Yes, the driver supports being used as pin controller with the
"bias-pull-up;" property now. For example I use this with a RPi
to enable pull-ups for all pins:

gpio21: gpio@21 {
        compatible = "microchip,mcp23017";
        gpio-controller;
        #gpio-cells = <0x2>;
        reg = <0x21>;
        interrupt-parent = <&socgpio>;
        interrupts = <0x17 0x8>;
        interrupt-names = "mcp23017@21 irq";
        interrupt-controller;
        #interrupt-cells = <0x2>;
        microchip,irq-mirror;
        pinctrl-names = "default";
        pinctrl-0 = <&i2cgpio0irq &gpio21pullups>;

        gpio21pullups: pinmux {
                pins = "gpio0", "gpio1", "gpio2", "gpio3",
                       "gpio4", "gpio5", "gpio6", "gpio7",
                       "gpio8", "gpio9", "gpio10", "gpio11",
                       "gpio12", "gpio13", "gpio14", "gpio15";
                bias-pull-up;
        };  
};

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)