linux-kernel - Re: [PATCH] tty: n_gsm: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507550442.3552.2.camel@perches.com>
Date:   Mon, 09 Oct 2017 05:00:42 -0700
From:   Joe Perches <joe@...ches.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        gregkh@...uxfoundation.org, jslaby@...e.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: n_gsm: pr_err() strings should end with newlines

On Mon, 2017-10-09 at 17:14 +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
[]
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
[]
> @@ -2788,7 +2788,7 @@ static int gsm_create_network(struct gsm_dlci *dlci, struct gsm_netconfig *nc)
>  	net = alloc_netdev(sizeof(struct gsm_mux_net), netname,
>  			   NET_NAME_UNKNOWN, gsm_mux_net_init);
>  	if (!net) {
> -		pr_err("alloc_netdev failed");
> +		pr_err("alloc_netdev failed\n");
>  		return -ENOMEM;
>  	}
>  	net->mtu = dlci->gsm->mtu;

You could just delete the pr_err instead.

It's an unnecessary message as there would
be a dump_stack() on the kvzalloc() in
alloc_netdev() on any OOM failure.