linux-kernel - Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7555b065-f4de-2988-283b-b6800ce189ab@linaro.org>
Date:   Mon, 9 Oct 2017 14:33:14 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, rui.zhang@...el.com,
        edubezval@...il.com
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings
 should end with newlines

On 09/10/2017 13:51, Arvind Yadav wrote:
> pr_err()/pr_info() messages should end with a new-line to avoid
> other messages being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/thermal/intel_powerclamp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
> index d718cd1..4540e89 100644
> --- a/drivers/thermal/intel_powerclamp.c
> +++ b/drivers/thermal/intel_powerclamp.c
> @@ -675,13 +675,13 @@ static int __init powerclamp_probe(void)
>  {
>  
>  	if (!x86_match_cpu(intel_powerclamp_ids)) {
> -		pr_err("CPU does not support MWAIT");
> +		pr_err("CPU does not support MWAIT\n");
>  		return -ENODEV;
>  	}
>  
>  	/* The goal for idle time alignment is to achieve package cstate. */
>  	if (!has_pkg_state_counter()) {
> -		pr_info("No package C-state available");
> +		pr_info("No package C-state available\n");
>  		return -ENODEV;
>  	}


Hi Arvind,

you are sending these fixes for all the drivers around. There is a way
to fix this once and for all: use the coccinelle tools [1], add the
script in the changelog with a big patchset and add the script in the
coccinelle scripts directory [2].

  -- Daniel

[1] Documentation/dev-tools/coccinelle.rst
[2] scripts/coccinelle/misc


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog