linux-kernel - Re: [PATCH] kbuild: comments cleanup in Makefile.lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59DAF04B.2050601@cn.fujitsu.com>
Date:   Mon, 9 Oct 2017 11:43:07 +0800
From:   Cao jin <caoj.fnst@...fujitsu.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Marek <mmarek@...e.com>
Subject: Re: [PATCH] kbuild: comments cleanup in Makefile.lib

Masahiro-san,

On 10/04/2017 12:58 PM, Masahiro Yamada wrote:
> Hi Cao,
> 
> 
> 2017-09-19 20:36 GMT+09:00 Cao jin <caoj.fnst@...fujitsu.com>:
>> It has:
>> 1. Move comments close to what it want to comment.
>> 2. Comments cleanup & improvement.
>>
>> Signed-off-by: Cao jin <caoj.fnst@...fujitsu.com>


>>
>> -# if $(foo-objs) exists, foo.o is a composite object
>> +# if $(foo-objs) or $(foo-y) or $(foo-m) exists, foo.o is a composite object
> 
> 
> Nit:
> 
> "if $(foo-objs), $(foo-y), or $(foo-m) exists" will be better.
> 

Yes, true.

>>  multi-used-y := $(sort $(foreach m,$(obj-y), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y))), $(m))))
>>  multi-used-m := $(sort $(foreach m,$(obj-m), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y)) $($(m:.o=-m))), $(m))))
>>  multi-used   := $(multi-used-y) $(multi-used-m)
>> @@ -90,7 +84,6 @@ subdir-ym     := $(addprefix $(obj)/,$(subdir-ym))
>>  obj-dirs       := $(addprefix $(obj)/,$(obj-dirs))
>>
>>  # These flags are needed for modversions and compiling, so we define them here
>> -# already
>>  # $(modname_flags) #defines KBUILD_MODNAME as the name of the module it will
> 
> 
> I am not sure if "#defines" is intentional or not.
> I think "#" is unnecessary.
> 

Yes, agree with you

-- 
Sincerely,
Cao jin