linux-kernel - [BUG] vt6655: A possible sleep-in-atomic bug in vt6655

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3f4b129-471e-6ccd-a2fa-6ffd915bcb7f@163.com>
Date:   Mon, 9 Oct 2017 09:10:28 +0800
From:   Jia-Ju Bai <baijiaju1990@....com>
To:     forest@...ttletooquiet.net, gregkh@...uxfoundation.org,
        simon@...anor.nu, tvboxspy@...il.com, scott@...heina.com,
        dan.a.cashman@...il.com, golubev.mikhail@...il.com,
        bhelgaas@...gle.com
Cc:     devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-pci@...r.kernel.org
Subject: [BUG] vt6655: A possible sleep-in-atomic bug in vt6655_suspend

According to device_main.c, the driver may sleep under a spinlock,
and the function call path is:
vt6655_suspend (acquire the spinlock)
   pci_set_power_state
     __pci_start_power_transition (drivers/pci/pci.c)
       msleep --> may sleep

A possible fix is to replace msleep with mdelay in 
__pci_start_power_transition in drivers/pci/pci.c.

This bug is found by my static analysis tool and my code review.


Thanks,
Jia-Ju Bai