| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Oct 2017 23:16:28 +0800
From: Fengguang Wu <fengguang.wu@...el.com>
To: Masami Hiramatsu <mhiramat@...nel.org>
Cc: wfg@...ux.intel.com, Ingo Molnar <mingo@...nel.org>,
linux-kernel@...r.kernel.org, LKP <lkp@...org>
Subject: [kprobes/x86] a19b2e3d78 [ 0.887669] WARNING: CPU: 0 PID: 1 at
kernel/locking/lockdep.c:2962 trace_hardirqs_off_caller
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
commit a19b2e3d783964d48d2b494439648e929bcdc976
Author: Masami Hiramatsu <mhiramat@...nel.org>
AuthorDate: Tue Sep 19 19:02:20 2017 +0900
Commit: Ingo Molnar <mingo@...nel.org>
CommitDate: Thu Sep 28 09:25:50 2017 +0200
kprobes/x86: Remove IRQ disabling from ftrace-based/optimized kprobes
Kkprobes don't need to disable IRQs if they are called from the
ftrace/jump trampoline code, because Documentation/kprobes.txt says:
-----
Probe handlers are run with preemption disabled. Depending on the
architecture and optimization state, handlers may also run with
interrupts disabled (e.g., kretprobe handlers and optimized kprobe
handlers run without interrupt disabled on x86/x86-64).
-----
So let's remove IRQ disabling from those handlers.
Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Alexei Starovoitov <ast@...com>
Cc: Alexei Starovoitov <ast@...nel.org>
Cc: Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Paul E . McKenney <paulmck@...ux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/150581534039.32348.11331736206004264553.stgit@devbox
Signed-off-by: Ingo Molnar <mingo@...nel.org>
5bb4fc2d86 kprobes/x86: Disable preemption in ftrace-based jprobes
a19b2e3d78 kprobes/x86: Remove IRQ disabling from ftrace-based/optimized kprobes
4b50239a76 Merge tag 'perf-core-for-mingo-4.15-20171003' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core
3769677b7c Merge branch 'perf/urgent'
1418b85217 Add linux-next specific files for 20170929
+----------------------------------------------------------------+------------+------------+------------+------------+---------------+
| | 5bb4fc2d86 | a19b2e3d78 | 4b50239a76 | 3769677b7c | next-20170929 |
+----------------------------------------------------------------+------------+------------+------------+------------+---------------+
| boot_successes | 2 | 0 | 0 | 8 | 0 |
| boot_failures | 134 | 15 | 19 | 22 | 53 |
| WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page | 134 | 11 | 15 | 22 | 33 |
| EIP:note_page | 134 | 11 | 15 | 22 | 33 |
| WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller | 0 | 15 | 19 | 0 | 53 |
| EIP:trace_hardirqs_off_caller | 0 | 15 | 19 | 0 | 53 |
+----------------------------------------------------------------+------------+------------+------------+------------+---------------+
[ 0.871996] spin_lock-torture: lock_torture_stats task started
[ 0.873322] Kprobe smoke test: started
[ 0.876126] audit: type=2000 audit(1507315296.900:1): state=initialized audit_enabled=0 res=1
[ 0.887039] DEBUG_LOCKS_WARN_ON(!irqs_disabled())
[ 0.887049] ------------[ cut here ]------------
[ 0.887669] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2962 trace_hardirqs_off_caller+0x55/0x90
[ 0.888406] Modules linked in:
[ 0.888617] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.14.0-rc2-00179-ga19b2e3 #1
[ 0.889108] task: c0114000 task.stack: c0116000
[ 0.889415] EIP: trace_hardirqs_off_caller+0x55/0x90
[ 0.889739] EFLAGS: 00210246 CPU: 0
[ 0.889969] EAX: 00000025 EBX: c102e4e2 ECX: 00200046 EDX: 00000001
[ 0.890377] ESI: c0114000 EDI: cfa83c14 EBP: c0117e68 ESP: c0117e58
[ 0.890805] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[ 0.891166] CR0: 80050033 CR2: 00000000 CR3: 019a0000 CR4: 001406b0
[ 0.891568] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[ 0.891969] DR6: fffe0ff0 DR7: 00000400
[ 0.892233] Call Trace:
[ 0.892401] ? setjmp_pre_handler+0x70/0x88
[ 0.892677] ? kprobe_ftrace_handler+0x8c/0xc5
[ 0.892964] ? kprobe_target+0x5/0x13
[ 0.893215] ? arch_local_save_flags+0xb/0xb
[ 0.893521] ? ftrace_ops_assist_func+0x8c/0xcc
[ 0.893823] ? ftrace_regs_call+0x5/0x28
[ 0.894085] ? kprobe_target+0x1/0x13
[ 0.894332] ? init_test_probes+0x1e3/0x423
[ 0.894607] ? init_kprobes+0x169/0x193
[ 0.894859] ? debugfs_kprobe_init+0x99/0x99
[ 0.895140] ? do_one_initcall+0x83/0x11e
[ 0.895401] ? parse_args+0x189/0x290
[ 0.895643] ? kernel_init_freeable+0x16b/0x209
[ 0.895938] ? kernel_init_freeable+0x187/0x209
[ 0.896245] ? rest_init+0xb3/0xb3
[ 0.896473] ? kernel_init+0xd/0xda
[ 0.896706] ? ret_from_fork+0x19/0x24
[ 0.896954] Code: 2d fc ff ff 0f ba e0 09 73 4c e8 a2 91 16 00 85 c0 74 4c 83 3d 2c 78 0e c2 00 75 43 68 8b 98 65 c1 68 5a c7 64 c1 e8 b7 e2 00 00 <0f> ff 58 5a eb 2e 8b 86 3c 05 00 00 c7 86 50 05 00 00 00 00 00
[ 0.898212] ---[ end trace fccb7e2c01067bac ]---
[ 0.921090] Kprobe smoke test: passed successfully
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 168c7384a5068e043a454e4d6189ab18f8edaa64 9e66317d3c92ddaab330c125dfe9d06eee268aff --
git bisect good 10a0c00f3d5d0781c110d9a2736d4fdb8c384456 # 22:12 G 11 0 11 13 Merge 'ath6kl/master' into devel-spot-201710061619
git bisect bad 8393f1c66042157cea223c95f9a3e28e1a46693e # 01:03 B 0 11 39 15 Merge 'usb/usb-next' into devel-spot-201710061619
git bisect good 4bd7121b1c8b9586df86239daa31f092a3f88236 # 01:30 G 11 0 11 35 Merge 'pci/pci/switchtec' into devel-spot-201710061619
git bisect good 0bb24a2a16dd2711422021045a0526a0378f8fa6 # 01:33 G 11 0 10 21 Merge 'asoc/for-linus' into devel-spot-201710061619
git bisect good d8e14b41d2f8c8df231b6bb50d11959889fcb922 # 01:38 G 11 0 11 26 Merge 'asoc/topic/dapm' into devel-spot-201710061619
git bisect bad bfdea03d1cf156d1b889eafd406335af1ef9b9ee # 01:38 B 0 15 28 0 Merge 'perf/tmp.perf/mt_record' into devel-spot-201710061619
git bisect good c896f85a7c15ab9d040ffac8b8003e47996602a2 # 01:48 G 11 0 11 26 perf tools: Fix leaking rec_argv in error cases
git bisect bad 5bce9db1894c998c5b85a34036d679ea6517668f # 01:48 B 0 26 66 0 perf/core: Explain perf_sched_mutex
git bisect good 4f56186ec051033848a669f1b145162d1c53e854 # 01:57 G 11 0 11 24 Merge branch 'linus' into perf/core, to refresh the branch
git bisect good e863d5396146411b615231cae0c518cb2a23371c # 02:00 G 11 0 11 22 kprobes: Warn if optprobe handler tries to change execution path
git bisect good 5bb4fc2d8641219732eb2bb654206775a4219aca # 04:42 G 11 0 11 101 kprobes/x86: Disable preemption in ftrace-based jprobes
git bisect bad 4c4de7d3c8383e3bf122cd84c61e7523df02b1ae # 04:42 B 0 26 66 0 Merge branch 'perf/urgent' into perf/core, to pick up fixes
git bisect bad a19b2e3d783964d48d2b494439648e929bcdc976 # 04:42 B 0 15 28 0 kprobes/x86: Remove IRQ disabling from ftrace-based/optimized kprobes
# first bad commit: [a19b2e3d783964d48d2b494439648e929bcdc976] kprobes/x86: Remove IRQ disabling from ftrace-based/optimized kprobes
git bisect good 5bb4fc2d8641219732eb2bb654206775a4219aca # 05:04 G 33 0 33 134 kprobes/x86: Disable preemption in ftrace-based jprobes
# extra tests on HEAD of linux-devel/devel-spot-201710061619
git bisect bad c09c961848967c7cf1ecf420203c53779de705cc # 05:04 B 0 13 29 0 0day head guard for 'devel-spot-201710061619'
# extra tests on tree/branch tip/perf/core
git bisect bad 4b50239a769e78bbe362fc92c3f8bd5415a4a5f5 # 05:10 B 0 19 52 0 Merge tag 'perf-core-for-mingo-4.15-20171003' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core
# extra tests with first bad commit reverted
git bisect good 84e9ec1e70b4cbe26b6783360334b072c7767752 # 05:13 G 11 0 11 22 Revert "kprobes/x86: Remove IRQ disabling from ftrace-based/optimized kprobes"
# extra tests on tree/branch tip/master
git bisect good 3769677b7cfa0123fad5dfb14981a817d04df4a5 # 05:26 G 11 0 11 22 Merge branch 'perf/urgent'
# extra tests on tree/branch linux-next/master
git bisect bad 1418b852174ad50b3cb4738b8801626aefdc0bd9 # 05:26 B 0 53 86 0 Add linux-next specific files for 20170929
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
Download attachment "dmesg-openwrt-lkp-hsw01-102:20171007024327:i386-randconfig-h0-10061955:4.14.0-rc2-00179-ga19b2e3:1.gz" of type "application/gzip" (13998 bytes)
Download attachment "dmesg-openwrt-lkp-hsw01-101:20171007030539:i386-randconfig-h0-10061955:4.14.0-rc2-00178-g5bb4fc2:2.gz" of type "application/gzip" (13571 bytes)
View attachment "reproduce-openwrt-lkp-hsw01-102:20171007024327:i386-randconfig-h0-10061955:4.14.0-rc2-00179-ga19b2e3:1" of type "text/plain" (897 bytes)
View attachment "config-4.14.0-rc2-00179-ga19b2e3" of type "text/plain" (104286 bytes)
Powered by blists - more mailing lists