linux-kernel - Re: [PATCH workqueue/for-4.14-fixes] workqueue: replace pool->manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171009153356.GF3301751@devbig577.frc2.facebook.com>
Date:   Mon, 9 Oct 2017 08:33:56 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Lai Jiangshan <jiangshanlai@...il.com>
Cc:     Boqun Feng <boqun.feng@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Josef Bacik <josef@...icpanda.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH workqueue/for-4.14-fixes] workqueue: replace
 pool->manager_arb mutex with a flag

Hello, Lai.

On Mon, Oct 09, 2017 at 11:14:20PM +0800, Lai Jiangshan wrote:
> > wait_event_lock_irq() drops the lock if the condition is not met
> > before going to sleep (otherwise it wouldn't be able to sleep).
> 
> I think just using get_pwq()/put_pwq() in manage_workers()
> as the following said is simpler than using wait_event_lock_irq()

Hmm... let's stay with the current implementation for the fix as it's
more straight-forward.  We can simplify it later if that'd be
worthwhile.

Thanks.

-- 
tejun