linux-kernel - Re: [PATCH] usb: musb: Check for host-mode using is_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171009160343.GC32614@uda0271908>
Date:   Mon, 9 Oct 2017 11:03:43 -0500
From:   Bin Liu <b-liu@...com>
To:     Jonathan Liu <net147@...il.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>, <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH] usb: musb: Check for host-mode using is_host_active() on
 reset interrupt

Hi,

On Wed, Sep 27, 2017 at 08:35:22PM +1000, Jonathan Liu wrote:
> The sunxi musb has a bug where sometimes it will generate a babble
> error on device disconnect instead of a disconnect IRQ. When this
> happens the musb controller switches from host mode to device mode
> (it clears MUSB_DEVCTL_HM/MUSB_DEVCTL_SESSION and sets
> MUSB_DEVCTL_BDEVICE) and gets stuck in this state.
> 
> The babble error is misdetected as a bus reset because MUSB_DEVCTL_HM
> was cleared.
> 
> To fix this, use is_host_active() rather than (devctl & MUSB_DEVCTL_HM)
> to detect babble error so that sunxi musb babble recovery can handle it
> by restoring the mode. This information is provided by the driver logic
> and does not rely on register contents.
> 
> Cc: stable@...r.kernel.org # v4.1+
> Signed-off-by: Jonathan Liu <net147@...il.com>

Applied. Thanks.
-Bin.