linux-kernel - Re: [PATCH] direct-io: Prevent NULL pointer access in submit_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171009162222.GW21978@ZenIV.linux.org.uk>
Date:   Mon, 9 Oct 2017 17:22:22 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Andreas Gruenbacher <agruenba@...hat.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, cluster-devel@...hat.com
Subject: Re: [PATCH] direct-io: Prevent NULL pointer access in
 submit_page_section

On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote:
> In the code added to function submit_page_section by commit b1058b981,
> sdio->bio can currently be NULL when calling dio_bio_submit.  This then
> leads to a NULL pointer access in dio_bio_submit, so check for a NULL
> bio in submit_page_section before trying to submit it instead.
> 
> Fixes xfstest generic/250 on gfs2.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
> Reviewed-by: Jan Kara <jack@...e.cz>

How far back in -stable should it go?  I'm fine with the patch, but I'd
rather have accurate Cc: stable in commit message...