linux-kernel - Re: [PATCH v2] isdn/gigaset: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKPm_KnLsS9Aj==r5fb7WCncFetKrbzdA4xkiW3ujx62Q@mail.gmail.com>
Date:   Mon, 9 Oct 2017 10:36:14 -0700
From:   Kees Cook <keescook@...omium.org>
To:     David Laight <David.Laight@...lab.com>
Cc:     Paul Bolle <pebolle@...cali.nl>,
        Karsten Keil <isdn@...ux-pingi.de>,
        "David S. Miller" <davem@...emloft.net>,
        Johan Hovold <johan@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "gigaset307x-common@...ts.sourceforge.net" 
        <gigaset307x-common@...ts.sourceforge.net>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

On Mon, Oct 9, 2017 at 2:15 AM, David Laight <David.Laight@...lab.com> wrote:
> From: Kees Cook
>> Sent: 06 October 2017 20:40
> ...
>> I'm in no rush for any specific change. There are about 900 call sites
>> I'm making my way through, about 2/3rd are pretty trivial, and the
>> less obvious is what I've started sending out now, since I expect some
>> will need some more careful review.
>
> Is it worth adding a structure that contains a timer and an extra 'long'
> than can be used to maintain the existing API logic for the 'difficult'
> cases?

I didn't want to have this available in the general case, since I'd
like to get all the conversions actually finished. There are a couple
very special cases that need this, and they have one-off structs that
do this.

-Kees

-- 
Kees Cook
Pixel Security