linux-kernel - Re: [PATCH] net: can: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKcQ0ez7dEma5fJv3DjWABAoEm+9P_G6aMcdBv6MHnsdQ@mail.gmail.com>
Date:   Mon, 9 Oct 2017 11:09:21 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        "David S. Miller" <davem@...emloft.net>, linux-can@...r.kernel.org,
        Network Development <netdev@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] net: can: Convert timers to use timer_setup()

On Mon, Oct 9, 2017 at 10:53 AM, Marc Kleine-Budde <mkl@...gutronix.de> wrote:
> On 10/05/2017 02:51 AM, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>>
>> Cc: Oliver Hartkopp <socketcan@...tkopp.net>
>> Cc: Marc Kleine-Budde <mkl@...gutronix.de>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: linux-can@...r.kernel.org
>> Cc: netdev@...r.kernel.org
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> ---
>> This requires commit 686fef928bba ("timer: Prepare to change timer
>> callback argument type") in v4.14-rc3, but should be otherwise
>> stand-alone.
>
> Are you taking the patch or should I apply it?
>
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>

If you have -rc3 in your tree, please take it. If you want the timers
tree to carry it instead, we can do that too.

Thanks!

-Kees

-- 
Kees Cook
Pixel Security