linux-kernel - Re: [PATCH] leds: tca6507: Remove unnecessary reg check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Oct 2017 20:43:04 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Christos Gkekas <chris.gekas@...il.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: tca6507: Remove unnecessary reg check

Hi Christos,

Thanks for the patch.

On 10/08/2017 08:55 PM, Christos Gkekas wrote:
> Variable reg is unsigned so checking whether it is less than zero is not
> necessary.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@...il.com>
> ---
>  drivers/leds/leds-tca6507.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index 45222a7..c12c16f 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -715,7 +715,7 @@ tca6507_led_dt_init(struct i2c_client *client)
>  		if (of_property_match_string(child, "compatible", "gpio") >= 0)
>  			led.flags |= TCA6507_MAKE_GPIO;
>  		ret = of_property_read_u32(child, "reg", &reg);
> -		if (ret != 0 || reg < 0 || reg >= NUM_LEDS)
> +		if (ret != 0 || reg >= NUM_LEDS)
>  			continue;
>  
>  		tca_leds[reg] = led;
> 

Applied.

-- 
Best regards,
Jacek Anaszewski