linux-kernel - RE: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering capability for requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b5cc33ec5f444a58cff4aec90f799ac@ausx13mpc120.AMER.DELL.COM>
Date:   Tue, 10 Oct 2017 20:31:11 +0000
From:   <Mario.Limonciello@...l.com>
To:     <pali.rohar@...il.com>
CC:     <dvhart@...radead.org>, <andy.shevchenko@...il.com>,
        <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <luto@...nel.org>,
        <quasisec@...gle.com>, <rjw@...ysocki.net>, <mjg59@...gle.com>,
        <hch@....de>, <greg@...ah.com>
Subject: RE: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering
 capability for requests

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@...il.com]
> Sent: Tuesday, October 10, 2017 1:32 PM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: dvhart@...radead.org; Andy Shevchenko <andy.shevchenko@...il.com>;
> LKML <linux-kernel@...r.kernel.org>; platform-driver-x86@...r.kernel.org;
> Andy Lutomirski <luto@...nel.org>; quasisec@...gle.com; rjw@...ysocki.net;
> mjg59@...gle.com; hch@....de; Greg KH <greg@...ah.com>
> Subject: Re: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering capability
> for requests
> 
> On Monday 09 October 2017 17:51:48 Mario Limonciello wrote:
> > +static struct token_range token_blacklist[] = {
> > +	{0x0000, 0x0175, 0x0176},
> > +	{0x0000, 0x0195, 0x0197},
> > +	{0x0000, 0x01DC, 0x01DD},
> > +	{0x0000, 0x027D, 0x0284},
> > +	{0x02E3, 0x0000, 0x0000},
> > +	{0x02FF, 0x0000, 0x0000},
> > +	{0x0000, 0x0300, 0x0302},
> > +	{0x0000, 0x0325, 0x0326},
> > +	{0x0000, 0x0332, 0x0335},
> > +	{0x0350, 0x0000, 0x0000},
> > +	{0x0363, 0x0000, 0x0000},
> > +	{0x0368, 0x0000, 0x0000},
> > +	{0x0000, 0x03F6, 0x03F7},
> > +	{0x0000, 0x049E, 0x049F},
> > +	{0x0000, 0x04A0, 0x04A3},
> > +	{0x0000, 0x04E6, 0x04E7},
> > +	{0x0000, 0x4000, 0x7FFF},
> > +	{0x0000, 0x9000, 0x9001},
> > +	{0x0000, 0xA000, 0xBFFF},
> > +	{0x0000, 0xEFF0, 0xEFFF},
> > +};
> 
> Hi! There should be information what is hidden in those tokens, so other
> people would be able to review why are those token blacklisted.
> 

I'll add some comments explaining what I can about why they're blacklisted.
Most of them are for use during manufacturing time and those I won't explain further.