linux-kernel - Re: [PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2017 10:42:50 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Branislav Radocaj <branislav@...ocaj.org>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        hans.verkuil@...co.com, devel@...verdev.osuosl.org,
        nikola.jelic83@...il.com, ran.algawi@...il.com,
        linux-kernel@...r.kernel.org, jb@...adie.fr, shilpapri@...il.com,
        aquannie@...il.com, linux-media@...r.kernel.org
Subject: Re: [PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in
 radio-bcm2048.c

Hi Branislav,

On Tue, Oct 10, 2017 at 03:29:19PM +0200, Branislav Radocaj wrote:
> This is a patch to the radio-bcm2048.c file that fixes up
> a warning found by the checkpatch.pl tool.
> 
> Signed-off-by: Branislav Radocaj <branislav@...ocaj.org>

Nice work, a few git log nit picks for you to ensure your future kernel development success.

You can read all this in Documentaton/process/submitting-patches.rst (section 2).

- You can use imperative mood, i.e 'Fix foo by doing bar' instead of 'This patch ...'
- We don't need to mention the file (either in the summary or in the body), people can see this from
  the diff.

This is one way of writing the git log message for checkpatch fixes

	checkpatch emits WARNING: EXPORT_SYMBOL(foo); should immediately follow
	its function/variable.

	Move EXPORT_SYMBOL macro call to immediately follow function definition.


Good work, hope this helps.

Tobin