lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Oct 2017 10:36:52 +0100 From: David Howells <dhowells@...hat.com> To: Peter Zijlstra <peterz@...radead.org> Cc: dhowells@...hat.com, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org, mingo@...nel.org, torvalds@...ux-foundation.org, mark.rutland@....com, linux-arch@...r.kernel.org, will.deacon@....com, Jonathan Corbet <corbet@....net>, Alexander Kuleshov <kuleshovmail@...il.com> Subject: Re: [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends() Peter Zijlstra <peterz@...radead.org> wrote: > > Now that smp_read_barrier_depends() is implied by READ_ONCE(), adding > > READ_ONCE() to assoc_array_ptr_to_leaf() and __assoc_array_ptr_to_meta() > > allows the several smp_read_barrier_depends() calls to be removed from > > lib/assoc_array.c. This commit makes this change. > > So arguably this code was broken for not already having READ_ONCE(). No, the code is right; this is the wrong place to use READ_ONCE(). The callers already call READ_ONCE() or ACCESS_ONCE(). David
Powered by blists - more mailing lists