linux-kernel - Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 11:24:36 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Hanjun Guo <guohanjun@...wei.com>
Cc:     Arvind Yadav <arvind.yadav.cs@...il.com>, hanjun.guo@...aro.org,
        sudeep.holla@....com, rjw@...ysocki.net, lenb@...nel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines

On Tue, Oct 10, 2017 at 05:33:50PM +0800, Hanjun Guo wrote:
> On 2017/9/25 15:24, Arvind Yadav wrote:
> > pr_err() messages should terminated with a new-line to avoid
> > other messages being concatenated onto the end.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> > ---
> > changes in v2:
> >              Add changelog.
> >
> >  drivers/acpi/arm64/gtdt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> > index 597a737..92f9edf 100644
> > --- a/drivers/acpi/arm64/gtdt.c
> > +++ b/drivers/acpi/arm64/gtdt.c
> > @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> >  	struct acpi_gtdt_timer_entry *gtdt_frame;
> >  
> >  	if (!block->timer_count) {
> > -		pr_err(FW_BUG "GT block present, but frame count is zero.");
> > +		pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> >  		return -ENODEV;
> >  	}
> >  
> 
> Make sense to me,
> 
> Acked-by: Hanjun Guo <hanjun.guo@...aro.org>
> 
> Lorenzo, could you pick this up for 4.15?

Sure, thanks for reminding.

Thanks,
Lorenzo