linux-kernel - Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171010012608.GA23555@codeaurora.org>
Date:   Mon, 9 Oct 2017 20:26:08 -0500
From:   Richard Kuo <rkuo@...eaurora.org>
To:     Cao jin <caoj.fnst@...fujitsu.com>
Cc:     linux-kernel@...r.kernel.org, linux-hexagon@...r.kernel.org
Subject: Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with
 KBUILD_CFLAGS_MODULE

On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote:
> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
> used to add arch-specific options for $(CC). From commandline,
> CFLAGS_MODULE shall be used.
> Doesn't have any functional change, but just follow kbuild rules.
> 
> Signed-off-by: Cao jin <caoj.fnst@...fujitsu.com>
> CC: Richard Kuo <rkuo@...eaurora.org>
> CC: linux-hexagon@...r.kernel.org
> ---
>  arch/hexagon/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile
> index 207711a0..4f5c84c 100644
> --- a/arch/hexagon/Makefile
> +++ b/arch/hexagon/Makefile
> @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums
>  
>  # Modules must use either long-calls, or use pic/plt.
>  # Use long-calls for now, it's easier.  And faster.
> -# CFLAGS_MODULE += -fPIC
> -# LDFLAGS_MODULE += -shared
> -CFLAGS_MODULE += -mlong-calls
> +# KBUILD_CFLAGS_MODULE += -fPIC
> +# KBUILD_LDFLAGS_MODULE += -shared
> +KBUILD_CFLAGS_MODULE += -mlong-calls
>  
>  cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
>  aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
> -- 
> 2.1.0
> 
> 
> 

For Hexagon:

Acked-by: Richard Kuo <rkuo@...eaurora.org>

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project