lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Oct 2017 17:20:08 +0200 From: Hannes Reinecke <hare@...e.de> To: Johannes Thumshirn <jthumshirn@...e.de>, "Martin K . Petersen" <martin.petersen@...cle.com> Cc: Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>, Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>, Lee Duncan <lduncan@...e.com>, Bart Van Assche <Bart.VanAssche@...disk.com>, Chris Leech <cleech@...hat.com> Subject: Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte On 10/09/2017 01:33 PM, Johannes Thumshirn wrote: > The SCSI host byte should be shifted left by 16 in order to have > scsi_decide_disposition() do the right thing (.i.e. requeue the command). > > Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de> > Fixes: 661134ad3765 ("[SCSI] libiscsi, bnx2i: make bound ep check common") > Cc: Lee Duncan <lduncan@...e.com> > Cc: Hannes Reinecke <hare@...e.de> > Cc: Bart Van Assche <Bart.VanAssche@...disk.com> > Cc: Chris Leech <cleech@...hat.com> > --- > drivers/scsi/libiscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index bd4605a34f54..9cba4913b43c 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -1728,7 +1728,7 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc) > > if (test_bit(ISCSI_SUSPEND_BIT, &conn->suspend_tx)) { > reason = FAILURE_SESSION_IN_RECOVERY; > - sc->result = DID_REQUEUE; > + sc->result = DID_REQUEUE << 16; > goto fault; > } > > Reviewed-by: Hannes Reinecke <hare@...e.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@...e.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
Powered by blists - more mailing lists