linux-kernel - Re: [PATCH] rpmsg: glink: keep balance of mutex locks in qcom_glink_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 11:26:38 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] rpmsg: glink: keep balance of mutex locks in
 qcom_glink_request_intent()

On Fri 06 Oct 14:23 PDT 2017, Alexey Khoroshilov wrote:

> If qcom_glink_tx() fails in qcom_glink_request_intent(),
> it returns immediately leaving intent_req_lock mutex locked.
> So the next tries to send intent request lead to deadlock.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Thanks Alexey.

This was found by Dan Carpenter a few weeks ago, but I failed to send
the pull request for it, will do so now.

Regards,
Bjorn