linux-kernel - Re: [PATCH] firmware: bluefield: add boot control driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <201710120701.QJQaTHcQ%fengguang.wu@intel.com>
Date:   Thu, 12 Oct 2017 07:49:21 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Chris Metcalf <cmetcalf@...lanox.com>
Cc:     kbuild-all@...org, Ingo Molnar <mingo@...nel.org>,
        linux-kernel@...r.kernel.org,
        Chris Metcalf <cmetcalf@...lanox.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Thierry Reding <treding@...dia.com>,
        Nishanth Menon <nm@...com>, Jean Delvare <jdelvare@...e.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH] firmware: bluefield: add boot control driver

Hi Chris,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.14-rc4 next-20171009]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Metcalf/firmware-bluefield-add-boot-control-driver/20171012-023624
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All error/warnings (new ones prefixed by >>):

>> drivers/firmware/mlx-bootctl.c:146:21: error: expected ')' before numeric constant
     DRIVER_ATTR(_name, 0600, _name##_show, _name##_store)
                        ^
>> drivers/firmware/mlx-bootctl.c:148:8: note: in expansion of macro 'MBC_DRV_ATTR'
    static MBC_DRV_ATTR(post_reset_wdog);
           ^~~~~~~~~~~~
>> drivers/firmware/mlx-bootctl.c:146:21: error: expected ')' before numeric constant
     DRIVER_ATTR(_name, 0600, _name##_show, _name##_store)
                        ^
   drivers/firmware/mlx-bootctl.c:149:8: note: in expansion of macro 'MBC_DRV_ATTR'
    static MBC_DRV_ATTR(reset_action);
           ^~~~~~~~~~~~
>> drivers/firmware/mlx-bootctl.c:146:21: error: expected ')' before numeric constant
     DRIVER_ATTR(_name, 0600, _name##_show, _name##_store)
                        ^
   drivers/firmware/mlx-bootctl.c:150:8: note: in expansion of macro 'MBC_DRV_ATTR'
    static MBC_DRV_ATTR(second_reset_action);
           ^~~~~~~~~~~~
>> drivers/firmware/mlx-bootctl.c:153:3: error: 'driver_attr_post_reset_wdog' undeclared here (not in a function)
     &driver_attr_post_reset_wdog.attr,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/firmware/mlx-bootctl.c:154:3: error: 'driver_attr_reset_action' undeclared here (not in a function)
     &driver_attr_reset_action.attr,
      ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/firmware/mlx-bootctl.c:155:3: error: 'driver_attr_second_reset_action' undeclared here (not in a function)
     &driver_attr_second_reset_action.attr,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware/mlx-bootctl.c:131:16: warning: 'second_reset_action_store' defined but not used [-Wunused-function]
    static ssize_t second_reset_action_store(struct device_driver *drv,
                   ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware/mlx-bootctl.c:124:16: warning: 'second_reset_action_show' defined but not used [-Wunused-function]
    static ssize_t second_reset_action_show(struct device_driver *drv,
                   ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/firmware/mlx-bootctl.c:110:16: warning: 'reset_action_store' defined but not used [-Wunused-function]
    static ssize_t reset_action_store(struct device_driver *drv,
                   ^~~~~~~~~~~~~~~~~~
   drivers/firmware/mlx-bootctl.c:103:16: warning: 'reset_action_show' defined but not used [-Wunused-function]
    static ssize_t reset_action_show(struct device_driver *drv,
                   ^~~~~~~~~~~~~~~~~
   drivers/firmware/mlx-bootctl.c:87:16: warning: 'post_reset_wdog_store' defined but not used [-Wunused-function]
    static ssize_t post_reset_wdog_store(struct device_driver *drv,
                   ^~~~~~~~~~~~~~~~~~~~~
   drivers/firmware/mlx-bootctl.c:81:16: warning: 'post_reset_wdog_show' defined but not used [-Wunused-function]
    static ssize_t post_reset_wdog_show(struct device_driver *drv,
                   ^~~~~~~~~~~~~~~~~~~~

vim +146 drivers/firmware/mlx-bootctl.c

   144	
   145	#define MBC_DRV_ATTR(_name) \
 > 146		DRIVER_ATTR(_name, 0600, _name##_show, _name##_store)
   147	
 > 148	static MBC_DRV_ATTR(post_reset_wdog);
 > 149	static MBC_DRV_ATTR(reset_action);
 > 150	static MBC_DRV_ATTR(second_reset_action);
   151	
   152	static struct attribute *mbc_dev_attrs[] = {
 > 153		&driver_attr_post_reset_wdog.attr,
 > 154		&driver_attr_reset_action.attr,
 > 155		&driver_attr_second_reset_action.attr,
   156		NULL
   157	};
   158	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57569 bytes)