linux-kernel - Re: [PATCH] scripts/checkpatch.pl: fix false warning of externschecking.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 20:29:09 -0700
From:   Joe Perches <joe@...ches.com>
To:     jiang.biao2@....com.cn
Cc:     apw@...onical.com, linux-kernel@...r.kernel.org,
        zhong.weidong@....com.cn
Subject: Re: [PATCH] scripts/checkpatch.pl: fix false warning of
 externschecking.

On Wed, 2017-10-11 at 11:21 +0800, jiang.biao2@....com.cn wrote:
> > On Tue, 2017-10-10 at 16:42 +0800, Jiang Biao wrote:
> > > When adding a function declaration in a .c file without an extern
> > > keywork decoration, checkpatch.pl will complain *externs should be
> > > avoided in .c files* false warning. This patch fix the bug.
> > nack.
> > The point is that external function declarations should be
> > done via #include.
> Hi Joe,

Hello Jiang

> Understood. But there are already some external function declarations in 
> .c files in current kernel, for instance line 505 in kernel/stop_machine.c,
> 
> extern void sched_set_stop_task(int cpu, struct task_struct *stop);
> 
> Should these be fixed? But maybe in some rare cases, external funciton 
> declarations in .c files are necessary.

Perhaps, but in those cases checkpatch messages should be ignored.

cheers, Joe