| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171011065445.GP1165@minitux>
Date: Tue, 10 Oct 2017 23:54:45 -0700
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Jia-Ju Bai <baijiaju1990@....com>
Cc: k.eugene.e@...il.com, kvalo@...eaurora.org,
wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in
wcn36xx_bss_info_changed
On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:
> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
>
Thanks, not sure how I could miss that one. Kalle can you please include
this in a v4.14-rc pull request?
:
Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration")
> Signed-off-by: Jia-Ju Bai <baijiaju1990@....com>
Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>
Regards,
Bjorn
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 35bd50b..b83f01d 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
> if (!sta) {
> wcn36xx_err("sta %pM is not found\n",
> bss_conf->bssid);
> - rcu_read_unlock();
> goto out;
> }
> sta_priv = wcn36xx_sta_to_priv(sta);
> --
> 1.7.9.5
>
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx
Powered by blists - more mailing lists