linux-kernel - Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2T+7_dVmWcdYhV85Mm-evzsMFf9RAo=GAvNGMfqWOxKw@mail.gmail.com>
Date:   Wed, 11 Oct 2017 09:53:09 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        gregkh <gregkh@...uxfoundation.org>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        Mark Rutland <mark.rutland@....com>,
        michael.opdenacker@...e-electrons.com, poeschel@...onage.de,
        andreas.noever@...il.com, gong.chen@...ux.intel.com,
        kheitke@...ience.com, Borislav Petkov <bp@...e.de>,
        DTML <devicetree@...r.kernel.org>,
        James Hogan <james.hogan@...tec.com>,
        Pawel Moll <pawel.moll@....com>, linux-arm-msm@...r.kernel.org,
        sharon.dvir1@...l.huji.ac.il, Rob Herring <robh+dt@...nel.org>,
        sdharia@...eaurora.org, Alan Cox <alan@...ux.intel.com>,
        Thierry Reding <treding@...dia.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>, jkosina@...e.cz,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Daniel Vetter <daniel@...ll.ch>, Joe Perches <joe@...ches.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to
 slimbus framework

On Wed, Oct 11, 2017 at 6:38 AM, Vinod Koul <vinod.koul@...el.com> wrote:
> On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandagatla@...aro.org wrote:
>> +     ctrl->pending_wr = kcalloc((ctrl->tx.n - 1),
>> +                                sizeof(struct slim_pending),
>> +                                GFP_KERNEL);
>> +     if (!ctrl->pending_wr) {
>> +             ret = -ENOMEM;
>> +             goto wr_alloc_failed;
>> +     }
>> +
>> +     sema_init(&ctrl->tx_sem, (ctrl->tx.n - 1));
>
> i though v5 comment from Arnd was not to use semaphores..

Right, these need to go away. Thanks for spotting it!

     Arnd