linux-kernel - Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2017 13:11:46 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     John Stultz <john.stultz@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>
Cc:     John Stultz <john.stultz@...aro.org>,
        Wei Xu <xuwei5@...ilicon.com>,
        Guodong Xu <guodong.xu@...aro.org>,
        Amit Pundir <amit.pundir@...aro.org>,
        YongQin Liu <yongqin.liu@...aro.org>,
        John Youn <johnyoun@...opsys.com>,
        Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>,
        Douglas Anderson <dianders@...omium.org>,
        Chen Yu <chenyu56@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux USB List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling


Hi,

John Stultz <john.stultz@...aro.org> writes:
> On Thu, Aug 17, 2017 at 12:03 PM, John Stultz <john.stultz@...aro.org> wrote:
>> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we
>> disconnect the gadget state"), I was trying to fix up the
>> fact that we somehow weren't disconnecting the gadget state,
>> so that when the OTG port was plugged in the second time we
>> would get warnings about the state tracking being wrong.
>>
>> The fix there was somewhat simple, as it just made sure to
>> call dwc2_hsotg_disconnect() before we connected things up
>> in OTG mode.
>>
>> But in looking at a different issue I was seeing with UDC
>> state handling, I realized that it would be much better
>> to call dwc2_hsotg_disconnect when we get the state change
>> signal moving to host mode.
>>
>> Thus, this patch removes the earlier disconnect call I added
>> and moves it (and the needed locking) to the host mode
>> transition.
>
> Ping? I don't mean to be a bother, but any thoughts on this patchset?

I'm not taking patches which John hasn't acked, sorry.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)