lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Oct 2017 15:51:32 +0530 From: Vinod Koul <vinod.koul@...el.com> To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> Cc: gregkh@...uxfoundation.org, broonie@...nel.org, alsa-devel@...a-project.org, mark.rutland@....com, michael.opdenacker@...e-electrons.com, poeschel@...onage.de, andreas.noever@...il.com, gong.chen@...ux.intel.com, arnd@...db.de, kheitke@...ience.com, bp@...e.de, devicetree@...r.kernel.org, james.hogan@...tec.com, pawel.moll@....com, linux-arm-msm@...r.kernel.org, sharon.dvir1@...l.huji.ac.il, robh+dt@...nel.org, sdharia@...eaurora.org, alan@...ux.intel.com, treding@...dia.com, mathieu.poirier@...aro.org, jkosina@...e.cz, linux-kernel@...r.kernel.org, daniel@...ll.ch, joe@...ches.com, davem@...emloft.net Subject: Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus On Wed, Oct 11, 2017 at 10:42:23AM +0100, Srinivas Kandagatla wrote: > On 11/10/17 05:07, Vinod Koul wrote: > >On Tue, Oct 10, 2017 at 06:21:34PM +0100, Srinivas Kandagatla wrote: > >>On 10/10/17 17:49, Vinod Koul wrote: > >>>>>>+/** > >>>>>>+ * slim_register_controller: Controller bring-up and registration. > >>... > >>>>>>+ > >>>>>>+ mutex_init(&ctrl->m_ctrl); > >>>>>>+ ret = device_register(&ctrl->dev); > >>>>> > >>>>>one more device_register?? Can you explain why > >>>>> > >>>> > >>>>This is a device for each controller. > >>> > >>>wont the controller have its own platform_device? > >> > >>Reason could be that slim_register controller can be called from any code > >>not just platform devices.. > > > >ah which cases would those be. I was expecting that you would have a > >platform_device as a slimbus controller which would call slim_register? > As of now there is only one controller which uses platform driver, but in > future there might be more, but this is something which makes the slimbus > core more flexible. even if you have more controllers wouldn't we have similar number of platform devices. Each instance of the link/controller would have its device node. Thanks -- ~Vinod
Powered by blists - more mailing lists