linux-kernel - Re: [PATCH v2] ARM: imx: Enable cpuidle for i.MX6DL starting at 1.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2017 14:09:57 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Leonard Crestez <leonard.crestez@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        Bai Ping <ping.bai@....com>
Subject: Re: [PATCH v2] ARM: imx: Enable cpuidle for i.MX6DL starting at 1.1

Am Mittwoch, den 11.10.2017, 15:08 +0300 schrieb Leonard Crestez:
> Enable cpuidle support on i.MX6DL starting from
> IMX_CHIP_REVISION_1_1.
> 
> This also makes the code cleaner because 6q and 6dl actually have
> different revision histories.
> 
> Signed-off-by: Bai Ping <ping.bai@....com>
> Signed-off-by: Leonard Crestez <leonard.crestez@....com>

Reviewed-by: Lucas Stach <l.stach@...gutronix.de>

> ---
> 
> Changes since v1: https://www.spinics.net/lists/arm-kernel/msg610461.
> html
> * Clarified comment but kept > instead of >= because that's what the
> old code used. Would be OK to change with further feedback.
> 
>  arch/arm/mach-imx/mach-imx6q.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-
> imx6q.c
> index 45801b2..5707113 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -371,10 +371,13 @@ static struct platform_device
> imx6q_cpufreq_pdev = {
>  static void __init imx6q_init_late(void)
>  {
>  	/*
> -	 * WAIT mode is broken on TO 1.0 and 1.1, so there is no
> point
> -	 * to run cpuidle on them.
> +	 * WAIT mode is broken on imx6 Dual/Quad revision 1.0 and
> 1.1 so
> +	 * there is no point to run cpuidle on them.
> +	 *
> +	 * It does work on imx6 Solo/DualLite starting from 1.1
>  	 */
> -	if (imx_get_soc_revision() > IMX_CHIP_REVISION_1_1)
> +	if ((cpu_is_imx6q() && imx_get_soc_revision() >
> IMX_CHIP_REVISION_1_1) ||
> +	    (cpu_is_imx6dl() && imx_get_soc_revision() >
> IMX_CHIP_REVISION_1_0))
>  		imx6q_cpuidle_init();
>  
>  	if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ)) {