linux-kernel - Re: [PATCH] 9p: set page uptodate when required in write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2017 12:27:43 +0000
From:   "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>
To:     "ericvh@...il.com" <ericvh@...il.com>,
        "rminnich@...dia.gov" <rminnich@...dia.gov>,
        "lucho@...kov.net" <lucho@...kov.net>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>
CC:     "v9fs-developer@...ts.sourceforge.net" 
        <v9fs-developer@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jack@...e.com" <jack@...e.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] 9p: set page uptodate when required in write_end()

Linus, Al,

Can one of you please pick this one directly?

This has been on LKML since April, but the 9p maintainers seem to be MIA?

On Thu, Jun 01, 2017 at 10:31:09PM -0400, Sasha Levin wrote:
>Ping?
>
>On Mon, Apr 10, 2017 at 02:46:57PM -0400, Sasha Levin wrote:
>> From: Alexander Levin <alexander.levin@...izon.com>
>>
>> Commit 77469c3f570 prevented setting the page as uptodate when we wrote the
>> right amount of data, fix that.
>>
>> Fixes: 77469c3f570 ("9p: saner ->write_end() on failing copy into non-uptodate page")
>> Reviewed-by: Jan Kara <jack@...e.com>
>> Signed-off-by: Alexander Levin <alexander.levin@...izon.com>
>> ---
>>  fs/9p/vfs_addr.c | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c
>> index adaf6f6..e1cbdfd 100644
>> --- a/fs/9p/vfs_addr.c
>> +++ b/fs/9p/vfs_addr.c
>> @@ -310,9 +310,13 @@ static int v9fs_write_end(struct file *filp, struct address_space *mapping,
>>
>>  	p9_debug(P9_DEBUG_VFS, "filp %p, mapping %p\n", filp, mapping);
>>
>> -	if (unlikely(copied < len && !PageUptodate(page))) {
>> -		copied = 0;
>> -		goto out;
>> +	if (!PageUptodate(page)) {
>> +		if (unlikely(copied < len)) {
>> +			copied = 0;
>> +			goto out;
>> +		} else if (len == PAGE_SIZE) {
>> +			SetPageUptodate(page);
>> +		}
>>  	}
>>  	/*
>>  	 * No need to use i_size_read() here, the i_size
>> --
>> 2.7.4
>
>-- 
>
>Thanks,
>Sasha

-- 

Thanks,
Sasha