lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Oct 2017 15:39:18 +0200 (CEST) From: Jiri Kosina <jikos@...nel.org> To: Joe Lawrence <joe.lawrence@...hat.com> cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org, Josh Poimboeuf <jpoimboe@...hat.com>, Jessica Yu <jeyu@...nel.org>, Miroslav Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com> Subject: Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails On Mon, 2 Oct 2017, Joe Lawrence wrote: > When an incoming module is considered for livepatching by > klp_module_coming(), it iterates over multiple patches and multiple > kernel objects in this order: > > list_for_each_entry(patch, &klp_patches, list) { > klp_for_each_object(patch, obj) { > > which means that if one of the kernel objects fails to patch, > klp_module_coming()'s error path needs to unpatch and cleanup any kernel > objects that were already patched by a previous patch. > > Reported-by: Miroslav Benes <mbenes@...e.cz> > Suggested-by: Petr Mladek <pmladek@...e.com> > Signed-off-by: Joe Lawrence <joe.lawrence@...hat.com> > --- > v2: > > - cleanup comment describing the new function > - s/klp_cleanup_module_objects_limited/klp_cleanup_module_patches_limited > - added a suggested-by tag for Petr since he suggested both code and > commentary :) Appplied to for-4.14/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs
Powered by blists - more mailing lists