linux-kernel - RE: [PATCH 1/1] vmbus: hvsock: add proper sync for vmbus_hvsock_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM5PR21MB0476C63F91ACBD982DD20AE3A04A0@DM5PR21MB0476.namprd21.prod.outlook.com>
Date:   Wed, 11 Oct 2017 13:55:26 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "apw@...onical.com" <apw@...onical.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "leann.ogasawara@...onical.com" <leann.ogasawara@...onical.com>,
        "marcelo.cerri@...onical.com" <marcelo.cerri@...onical.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 1/1] vmbus: hvsock: add proper sync for
 vmbus_hvsock_device_unregister()

Thanks Dan. Will do.

K. Y

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@...cle.com]
> Sent: Wednesday, October 11, 2017 2:42 AM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> vkuznets@...hat.com; jasowang@...hat.com;
> leann.ogasawara@...onical.com; marcelo.cerri@...onical.com; Stephen
> Hemminger <sthemmin@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>
> Subject: Re: [PATCH 1/1] vmbus: hvsock: add proper sync for
> vmbus_hvsock_device_unregister()
> 
> On Tue, Oct 10, 2017 at 10:38:51PM -0700, kys@...hange.microsoft.com
> wrote:
> > From: Dexuan Cui <decui@...rosoft.com>
> >
> > Without the patch, vmbus_hvsock_device_unregister() can destroy the
> device
> > prematurely when close() is called, and can cause NULl dereferencing or
> > potential data loss (the last portion of the data stream may be dropped
> > prematurely).
> >
> > Please consider this for 4.14.
> 
> Put these meta comments under the --- cut off line.  They don't add
> any value to the final upstream git log.
> 
> >
> > Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> > Cc: Haiyang Zhang <haiyangz@...rosoft.com>
> > Cc: Stephen Hemminger <sthemmin@...rosoft.com>
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > ---
> >  drivers/hv/channel_mgmt.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> 
> regards,
> dan carpenter