linux-kernel - Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <282bd0a3-4cf6-4269-c07f-a476aa0bb764@gmail.com>
Date:   Wed, 11 Oct 2017 08:12:34 -0600
From:   David Ahern <dsahern@...il.com>
To:     Colin King <colin.king@...onical.com>,
        "David S . Miller" <davem@...emloft.net>,
        Robert Shearman <rshearma@...cade.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Amine Kherbouche <amine.kherbouche@...nd.com>
Subject: Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen
 static

On 10/11/17 3:53 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function ipgre_mpls_encap_hlen is local to the source and
> does not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'ipgre_mpls_encap_hlen' was not declared. Should it be static?
> 
Fixes: bdc476413dcdb ("ip_tunnel: add mpls over gre support")

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  net/mpls/af_mpls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index 9745e8f69810..8ca9915befc8 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
> @@ -41,7 +41,7 @@ static int label_limit = (1 << 20) - 1;
>  static int ttl_max = 255;
>  
>  #if IS_ENABLED(CONFIG_NET_IP_TUNNEL)
> -size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
> +static size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
>  {
>  	return sizeof(struct mpls_shim_hdr);
>  }
> 

 Acked-by: David Ahern <dsahern@...il.com>