linux-kernel - Re: [PATCH] KVM: SVM: limit kvm_handle_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42e37c49-dacb-1449-635c-459f88add949@amd.com>
Date:   Wed, 11 Oct 2017 10:30:00 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     brijesh.singh@....com
Subject: Re: [PATCH] KVM: SVM: limit kvm_handle_page_fault to #PF handling

Hi Paolo,


On 10/10/2017 03:49 AM, Paolo Bonzini wrote:
...

> +
> +static int npf_interception(struct vcpu_svm *svm)
> +{
> +	u64 fault_address = svm->vmcb->control.exit_info_2;
> +	u64 error_code = svm->vmcb->control.exit_info_1;
> +
> +	trace_kvm_page_fault(fault_address, error_code);
> +	return kvm_mmu_page_fault(&svm->vcpu, error_code, fault_address,
                                               ^^^^^^^     ^^^^^

The argument order need to be swapped, second argument should be 
'fault_address' and third 'error_code'

         return kvm_mmu_page_fault(&svm->vcpu, fault_address, error_code,
                          svm->vmcb->control.insn_bytes,
                          svm->vmcb->control.insn_len);


With that fixed.

Reviewed-by: Brijesh Singh <brijesh.singh@....com>

thanks