linux-kernel - Re: [PATCH 2/3] srcu: queue work without holding the lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2017 09:46:47 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] srcu: queue work without holding the lock

On Wed, Oct 11, 2017 at 06:40:12PM +0200, Sebastian Andrzej Siewior wrote:
> On 2017-10-10 14:43:13 [-0700], Paul E. McKenney wrote:
> > > OK, internally I could get rid of raw_ at the expense of some code bloat,
> > > but in the call_srcu() case, the caller might well hold a raw_ lock.
> > 
> > Except that none currently do, so maybe downgrading from raw_ locks is
> > a reasonable course of action.  Does the following patch help?
> 
> so you revert the raw_ access, this should work. I will apply it
> tomorrow and let you know.

Indeed.  I checked and the current callers of call_srcu() are not
doing so while holding raw spinlocks.  Now, call_rcu() is quite a
different story...

							Thanx, Paul